change .rsp file comment char to fix package import script build failure #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes unitypackage import / script build errors.
westhom
force-pushed
the
rsp-comment-patch
branch
from
1cd1743 to
43b405b
Compare
westhom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the way the comment is formatted causes build errors during unitypackage import. The right click options in the hierarchy are not visible because all script compilation halted. This fixes that.
See this comment on unity forums: http://answers.unity.com/answers/1630246/view.html
Hotfix example package: https://www.dropbox.com/s/cnrqydrnn7na6ml/videolab-1.1.1-hotfix.unitypackage?dl=1
Examples that cause compilation to fail (on my unity 2018.4.20f1, macOS Catalina):
See comment in this issue for more discussion: #32 (comment)