-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tasks to cover PipelineResource use cases #95
Comments
Another part of this that we'll need to think about is that currently the PipelineResources have their credentials initialized using Pipeline's creds-init image. @bobcatfish and I were talking about this a bit last week / a few weeks ago. Maybe we could offer up creds-init as its own Task to ease migration off of PipelineResources? The only problem them would be that the user would need to provide a workspace so that the initialized creds can be written to it and then mounted at the appropriate place by the PipelineResource tasks themselves. Seems complicated to me. This is, I think, where having tasks with Pre and Post Run Steps could really help out - a creds-init PreRunStep could initialize a Task's |
With the addition of workspaces and results, we are exploring a world without PipelineResources! (see tektoncd/pipeline#1673) To that end, this commit adds a Task that does the same things as the PullRequest PipelineResource. It still uses the same underlying image, pullrequest-init, which is currently built and published as part of the Tekton Pipelines release, but which one day may be in another repo and published separately. This also includes a "sample" which uses the Task to post a comment on an existing known PR - the only requirement to run it is a secret that contains a github token. Part of tektoncd#95
With the addition of workspaces and results, we are exploring a world without PipelineResources! (see tektoncd/pipeline#1673) To that end, this commit adds a Task that does the same things as the PullRequest PipelineResource. It still uses the same underlying image, pullrequest-init, which is currently built and published as part of the Tekton Pipelines release, but which one day may be in another repo and published separately. This also includes a "sample" which uses the Task to post a comment on an existing known PR - the only requirement to run it is a secret that contains a github token. Part of tektoncd#95
With the addition of workspaces and results, we are exploring a world without PipelineResources! (see tektoncd/pipeline#1673) To that end, this commit adds a Task that does the same things as the PullRequest PipelineResource. It still uses the same underlying image, pullrequest-init, which is currently built and published as part of the Tekton Pipelines release, but which one day may be in another repo and published separately. This also includes a "sample" which uses the Task to post a comment on an existing known PR - the only requirement to run it is a secret that contains a github token. Part of tektoncd#95
With the addition of workspaces and results, we are exploring a world without PipelineResources! (see tektoncd/pipeline#1673) To that end, this commit adds a Task that does the same things as the PullRequest PipelineResource. It still uses the same underlying image, pullrequest-init, which is currently built and published as part of the Tekton Pipelines release, but which one day may be in another repo and published separately. This also includes a "sample" which uses the Task to post a comment on an existing known PR - the only requirement to run it is a secret that contains a github token. Part of #95
Kubeconfigwriter needs to improved to replace pipeline resource type "cluster" with the kubeconfig-creator task. In order to do that, some extra configurations(e.g. client-key-data, client-certificate-data) needs to be added with some changes in the implementation. Ref: [tektoncd/catalog#95], [tektoncd/catalog#251] Signed-off-by: Divyansh42 <[email protected]>
Kubeconfigwriter needs to be improved to replace pipeline resource type "cluster" with the kubeconfig-creator task. In order to do that, some extra configurations(e.g. client-key-data, client-certificate-data) needs to be added in the Resource struct with some changes in the kubeconfigwriter implementation. Ref: [tektoncd/catalog#95], [tektoncd/catalog#251] Signed-off-by: Divyansh42 <[email protected]>
Kubeconfigwriter needs to be improved to replace pipeline resource type "cluster" with the kubeconfig-creator task. In order to do that, some extra configurations(e.g. client-key-data, client-certificate-data) needs to be added in the Resource struct with some changes in the kubeconfigwriter implementation. Ref: [tektoncd/catalog#95], [tektoncd/catalog#251] Signed-off-by: Divyansh42 <[email protected]>
This is a part of documenting and providing task in the catalog that would help user not using PipelineResource for accesing the target cluster. This can help in creating a kubeconfig file by providing cluster credentials to the task. Ref:#95 Signed-off-by: Divyansh42 <[email protected]>
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Oof missed the note in the docs. Thanks.
…On Thu, Jan 28, 2021, 12:36 AM Vinamra Jain ***@***.***> wrote:
hi @stobias123 <https://github.com/stobias123>, Using SSH authentication
in git type Tasks
<https://github.com/tektoncd/pipeline/blob/master/docs/auth.md#using-ssh-authentication-in-git-type-tasks>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQGVPPILLBYUFWLBN2MQLS4EOYVANCNFSM4I5CJE3Q>
.
|
In the recent PipelineResource working group and as presented during Oct. 2 working group, and related to tektoncd/pipeline#1369 :
In the most recent PipelineResource working group we landed on the idea of keeping PipelineResources as Alpha when the rest of the Tekton resources move to Beta. So with that approach we'll need to make sure that our docs correctly reflect the "right" way to work with external resources.
In this direction, we need to provide generic tasks that cover the use case of PipelineResource today, e.g. a GitTask, a DockerImageTask, etc... This issue is there to track work related to that.
Current PipelineResource to cover
GitResource
Add a git task to clone a repository without PipelineResource #123ClusterResource
PullRequestResource
GCSResource
S3resource
Additionnal generic tasks
mercurial
, …Feel free to add your ideas/need in comment, I'll update this issue's description 😉
The text was updated successfully, but these errors were encountered: