-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jib-gradle task #199
Fix jib-gradle task #199
Conversation
This wil fix the issue jib gradle task gettng failed on security constrained environments like OpenShift Fix tektoncd#198
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-tekton-catalog-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hrishin, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@piyush-garg I can't see how this actually helps. The gradle home is already defined using the system property: https://github.com/tektoncd/catalog/pull/199/files#diff-218c88f355db45e8a7a0e2bc9e76ac0eR48 Can you provide an explanation as to how this works? and why it's necessary? Is
|
And this actually breaks caching. I don't think this is the right fix. We should revert it.
|
This comment: gradle/gradle#8107 (comment) seems to indicate that it's a problem with the permissions of the |
This wil fix the issue jib gradle task
gettng failed on security constrained
environments like OpenShift
Fix #198
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.