Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0028: Task Execution Status at Runtime - Mark as Implemented #451

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 3, 2021

Implemented in tektoncd/pipeline#3390

/kind cleanup
/cc @pritidesai

@tekton-robot tekton-robot requested a review from pritidesai June 3, 2021 20:07
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2021
@pritidesai
Copy link
Member

/approve

Thanks a bunch @jerop for taking care of this. We would ideally want to include the implementation PR in reference section while moving to this state.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
@pritidesai
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2021
@tekton-robot tekton-robot merged commit 0de82f5 into tektoncd:main Jun 3, 2021
@jerop
Copy link
Member Author

jerop commented Jun 3, 2021

Thanks a bunch @jerop for taking care of this. We would ideally want to include the implementation PR in reference section while moving to this state.

that's a great idea, we could add it as an option in the TEP metadata instead of the references so it's more highlighted

cc @vdemeester

@jerop jerop deleted the tep-0028-implemented branch January 6, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Implemented
Development

Successfully merging this pull request may close these issues.

3 participants