Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0100: Embedded TaskRuns and Runs Status in PipelineRuns [Problem Statement] #606

Merged
merged 1 commit into from
Jan 31, 2022
Merged

TEP-0100: Embedded TaskRuns and Runs Status in PipelineRuns [Problem Statement] #606

merged 1 commit into from
Jan 31, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jan 24, 2022

This TEP proposes changes to PipelineRun Status to reduce the amount of
information stored about the status of its Runs and TaskRuns to improve
performance, reduce memory bloat and improve extensibility.

Related Issues:

Related TEPs:

/kind tep

Co-authored-by: Lee Bernick [email protected]

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Jan 24, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 24, 2022
@jerop
Copy link
Member Author

jerop commented Jan 24, 2022

/cc @skaegi @imjasonh @bobcatfish @sbwsg @abayer @vdemeester @lbernick

(from previous discussions about pipelinerun status in tektoncd/pipeline#3140 and tektoncd/pipeline#3792)

@tekton-robot
Copy link
Contributor

@jerop: GitHub didn't allow me to request PR reviews from the following users: lbernick.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @skaegi @imjasonh @bobcatfish @sbwsg @abayer @vdemeester @lbernick

(from previous discussions about pipelinerun status in tektoncd/pipeline#3140 and tektoncd/pipeline#3792)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
@bobcatfish
Copy link
Contributor

/assign

@bobcatfish
Copy link
Contributor

ONE HUNDREDTH TEP!!! 🎉 🎉 🎉

image

dj cat celebration

@jerop
Copy link
Member Author

jerop commented Jan 25, 2022

putting a hold on this PR so it doesn't get merged on the first approval to give people more time to review

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2022
vdemeester
vdemeester reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

teps/0100-embedded-taskruns-and-runs-status-in-pipelineruns.md Outdated Show resolved Hide resolved
@bobcatfish
Copy link
Contributor

no particular feedback from me!

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2022
@jerop @lbernick
TEP-0100: Embedded TaskRuns and Runs Status in PipelineRuns [Problem …
a571ef2 
…Statement]

This TEP proposes changes to `PipelineRun` Status to reduce the amount of
information stored about the status of its `Run`s and `TaskRun`s to improve
performance, reduce memory bloat and improve extensibility.

Co-authored-by: Lee Bernick <[email protected]>
@jerop
Copy link
Member Author

jerop commented Jan 30, 2022

@imjasonh @chmouel @pritidesai @vdemeester thanks for the initial reviews - clarified the problem statement to address your comments, please take a look 🙏🏾

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chmouel
Copy link
Member

chmouel commented Jan 31, 2022

LGTM

@jerop
Copy link
Member Author

jerop commented Jan 31, 2022

/cancel hold

@afrittoli
Copy link
Member

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2022
@afrittoli
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@tekton-robot tekton-robot merged commit d8b37f8 into tektoncd:main Jan 31, 2022
@jerop jerop mentioned this pull request Jan 31, 2022
Merged
@cirocosta cirocosta mentioned this pull request Feb 22, 2022
Merged
4 tasks
@jerop jerop deleted the tep-100-ps branch June 11, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai left review comments

@chmouel chmouel chmouel left review comments

@vdemeester vdemeester vdemeester approved these changes

@houshengbo houshengbo Awaiting requested review from houshengbo

@skaegi skaegi Awaiting requested review from skaegi

@abayer abayer Awaiting requested review from abayer

@imjasonh imjasonh Awaiting requested review from imjasonh

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@vdemeester vdemeester

@imjasonh imjasonh

@bobcatfish bobcatfish

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jerop @tekton-robot @imjasonh @bobcatfish @chmouel @afrittoli @vdemeester @pritidesai