Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to see old logs at least for 24 hours past #232

Closed
alhazred opened this issue Jun 10, 2019 · 11 comments
Closed

Would like to see old logs at least for 24 hours past #232

alhazred opened this issue Jun 10, 2019 · 11 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@alhazred
Copy link

alhazred commented Jun 10, 2019

Expected Behavior

Possibility to view all pipelines/logs at least for the current day and the previous one

Actual Behavior

only when related pods are live

Steps to Reproduce the Problem

  1. jx start pipeline foo
  2. would like to see logs for any run for a day for example
  3. "Unable to fetch log" or even "Error loading pipeline run "Not Found" for old runs after some time

Additional Info

I understand that pods has a short live time but would be nice to keep their logs at least for last 24 hours

@AlanGreene
Copy link
Member

tektoncd/pipeline#107 is tracking a proposal that may be of interest for persistence of logs

@alhazred
Copy link
Author

It seems like solid approach, thanks

@mnuttall
Copy link
Contributor

mnuttall commented Jul 1, 2019

Hi @alhazred thank you for raising this. The dashboard currently shows logs for as long as the associated PipelineRun and TaskRun objects exist. Deleting those objects deletes the logs. If tektoncd/pipeline#107 leads to a general persistence mechanism then we'll have to decide whether or not dashboard should use it.

@arzarif
Copy link

arzarif commented Sep 10, 2019

Seems like the linked ticket has been closed in favor of standard pod log collection practices. Given that centralized log collection can vary from implementation to implementation, what recourse would the dashboard have as far as being able to present historical data?

@AlanGreene
Copy link
Member

This could be an interesting one to watch: https://github.com/tektoncd/experimental/tree/master/results

@eddycharly
Copy link
Member

Why not add something like ExternalAgentLogs in prow ?

@eddycharly
Copy link
Member

/assign
Related PR #1586

@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 15, 2020
@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

Logs can be persisted externally and displayed in the dashboard after the pods have been deleted by following https://github.com/tektoncd/dashboard/blob/master/docs/walkthrough/walkthrough-logs.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants