Add pull request update #138
Conversation
After the pull request is processed by the webhook, the task specified in the webhook updates the pull request with the pipeline run result.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akihikokuroda If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
size/L
| generatedPipelineRunName := fmt.Sprintf("%s-%s", webhook.Name, startTime) | ||
| generatedTaskRunName := generatedPipelineRunName | ||
|
|
||
| // Unique names are required so timestamp them. |
There was a problem hiding this comment.
There's loads of duplicated code here, do we want the branch name in as well (I recently added it for our generated PipelineRuns)? Can anything be extracted into methods to reduce duplication?
There was a problem hiding this comment.
I looked through these 2 methods. They look similar but they have only a little duplication. I would like to keep them this way.
| resourcePointer := &pipelineResource | ||
| return resourcePointer | ||
| } | ||
|
|
||
| /* Create a new PipelineResource: this should be of type git or image |
There was a problem hiding this comment.
Hmm can this now go or should we be using it instead of definePipelineResource?
There was a problem hiding this comment.
I remove this code.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
/retest |
|
could the params be changed to something like |
After the pull request is processed by the webhook,
the task specified in the webhook updates the
pull request with the pipeline run result.
The webhook updates the pull request after the pipeline execution when the github event is the pull request. The default task used to update the pull request is monitor-result-task and the comments added to the pull request are "OK" and "ERROR" based on the result of the pipelinerun.
The custom task can be set at the pulltask in the webhook. The comments can be set at pulltaskparam1 (for sccess) and pullraskparam2 (for failure) in the webhook.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.