Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Add dashboard helm chart #505

Merged
merged 6 commits into from
Apr 10, 2020
Merged

Add dashboard helm chart #505

merged 6 commits into from
Apr 10, 2020

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Apr 7, 2020 •
edited
Loading

This pull request adds a helm chart for Tekton Dashboard.

It is a follow up from the previous PR #494.
Helm chart support was proposed here: tektoncd/plumbing#278

This is work in progress, remaining TODOs:

  • doc
  • tests (tested with kind)

Minor issues:

I will try to make the dashboard not dependent of hardcoded namespaces and will update the chart accordingly.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2020
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 7, 2020
@tekton-robot
Copy link

Hi @eddycharly. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 7, 2020
@eddycharly
Copy link
Member Author

eddycharly commented Apr 7, 2020 •
edited
Loading

/cc @vdemeester

Any idea why pull-tekton-experimental-helm-lint prow job doesn't show up ? (tektoncd/plumbing#296)

@tekton-robot tekton-robot requested a review from vdemeester April 7, 2020 17:10
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2020
@afrittoli
Copy link
Member

/retest

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 8, 2020
@eddycharly eddycharly changed the title [WIP] Add dashboard helm chart Add dashboard helm chart Apr 8, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2020
@eddycharly
Copy link
Member Author

/retest

@eddycharly
Copy link
Member Author

/run tekton-experimental-helm-lint

1 similar comment
@eddycharly
Copy link
Member Author

/run tekton-experimental-helm-lint

@eddycharly
Copy link
Member Author

/run tekton-experimental-helm-lint
/joke

@tekton-robot
Copy link

@eddycharly: What has ears but cannot hear? A field of corn.

In response to this:

/run tekton-experimental-helm-lint
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eddycharly
Copy link
Member Author

/cc @afrittoli

This should be ready for review.

@tekton-robot tekton-robot requested a review from afrittoli April 8, 2020 13:24
vdemeester
vdemeester approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2020
@tekton-robot tekton-robot merged commit c2bdeee into tektoncd:master Apr 10, 2020
This was referenced Apr 14, 2020
Merged
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@kimsterv kimsterv Awaiting requested review from kimsterv

@mnuttall mnuttall Awaiting requested review from mnuttall

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eddycharly @tekton-robot @vdemeester @afrittoli