Skip to content

Commit

Permalink
Updates Operator for Results v0.3.1
Browse files Browse the repository at this point in the history
In v0.3.1, the db secret name is changed as Results API now uses a
Postgres implementation instead of MySQL.

Also, updates the CI to fetch 0.3.1 for testing instead of latest because
of a bug  tektoncd/results#138

Signed-off-by: Shivam Mukhade <[email protected]>
  • Loading branch information
Shivam Mukhade committed Nov 8, 2021
1 parent 35c7ea4 commit 4257020
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ KO = $(or ${KO_BIN},${KO_BIN},$(BIN)/ko)
PIPELINES ?= latest
TRIGGERS ?= latest
DASHBOARD ?= latest
RESULTS ?= latest
RESULTS ?= v0.3.1 # latest returns an older version hence hard coding to v0.3.1 for now (tektoncd/results#138)

$(BIN)/ko: PACKAGE=github.com/google/ko/cmd/ko

Expand Down
4 changes: 2 additions & 2 deletions docs/TektonResult.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ To install Tekton Result on your cluster follow steps as given below:
the following properties:

- namespace: `tekton-pipelines`
- name: `tekton-results-mysql`
- name: `tekton-results-postgres`
- contains the fields:
- `user=root`
- `password=<your password>`
Expand All @@ -30,7 +30,7 @@ To install Tekton Result on your cluster follow steps as given below:
Update namespace value in the command if Tekton Pipelines is installed in a different namespace..

```sh
$ kubectl create secret generic tekton-results-mysql --namespace=tekton-pipelines --from-literal=user=root --from-literal=password=$(openssl rand -base64 20)
$ kubectl create secret generic tekton-results-postgres --namespace=tekton-pipelines --from-literal=user=root --from-literal=password=$(openssl rand -base64 20)
```
- Generate cert/key pair.
Note: Feel free to use any cert management software to do this!
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/kubernetes/tektonresult/tektonresult.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import (
)

const (
DbSecretName = "tekton-results-mysql"
DbSecretName = "tekton-results-postgres"
TlsSecretName = "tekton-results-tls"
)

Expand Down
2 changes: 1 addition & 1 deletion test/config.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export PIPELINES=latest
export TRIGGERS=latest
export RESULTS=latest
export RESULTS=v0.3.1
export DASHBOARD=latest

0 comments on commit 4257020

Please sign in to comment.