Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update triggers to use v1beta1 and bump triggers, pipeline, knative and k8s version #388

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Update triggers to use v1beta1 and bump triggers, pipeline, knative and k8s version #388

merged 1 commit into from
Sep 3, 2021

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Aug 20, 2021 •
edited
Loading

Changes

  • Updated triggers code to use v1beta1
  • Bump pipeline, triggers, knative and k8s version
K8S_VERSION="v0.21.4"
TRIGGERS_VERSION="v0.16.0"
PIPELINE_VERSION="v0.27.3"
knative.dev/pkg v0.0.0-20210827184538-2bd91f75571c

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Updated triggers to use v1beta1 apis

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 20, 2021
@savitaashture savitaashture added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2021
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 20, 2021
@savitaashture savitaashture force-pushed the update-triggers-to-v1beta1 branch from f1a5317 to da1c686 Compare August 20, 2021 09:47
vdemeester
vdemeester requested changes Aug 20, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why .bin files have been added, they should be in the .gitignore 🤔

@savitaashture
Copy link
Contributor Author

I wonder why .bin files have been added, they should be in the .gitignore

that's added mistakenly while doing PR 😆

@savitaashture savitaashture force-pushed the update-triggers-to-v1beta1 branch from da1c686 to 34a644d Compare August 20, 2021 12:05
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2021
@savitaashture savitaashture force-pushed the update-triggers-to-v1beta1 branch 2 times, most recently from 20908db to 7875111 Compare August 20, 2021 12:10
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2021
@savitaashture savitaashture force-pushed the update-triggers-to-v1beta1 branch 4 times, most recently from e8f4f96 to 202fc7d Compare August 23, 2021 06:14
@savitaashture savitaashture removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@sm43
Copy link
Member

sm43 commented Aug 23, 2021

operator/pkg/reconciler/openshift/annotation/annotation.go

Line 145 in a1a0d67

APIVersions: []string{"v1alpha1"},

do we need to update the version here?

@savitaashture
Copy link
Contributor Author

operator/pkg/reconciler/openshift/annotation/annotation.go

Line 145 in a1a0d67

APIVersions: []string{"v1alpha1"},

do we need to update the version here?

Yes updated here https://github.com/tektoncd/operator/pull/388/files?file-filters%5B%5D=.go&hide-deleted-files=true#diff-b1cec14612915fa7e56c474b9dc04e14e1e246ec7ad9abd7390d2ad44cb36eadR145

@savitaashture savitaashture added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@savitaashture savitaashture force-pushed the update-triggers-to-v1beta1 branch from 202fc7d to 186377c Compare August 24, 2021 13:43
@savitaashture savitaashture removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@savitaashture savitaashture force-pushed the update-triggers-to-v1beta1 branch from 186377c to a41d1c6 Compare September 2, 2021 11:54
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2021
@savitaashture savitaashture force-pushed the update-triggers-to-v1beta1 branch from a41d1c6 to 3ff551f Compare September 2, 2021 12:20
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2021
@savitaashture savitaashture force-pushed the update-triggers-to-v1beta1 branch from 3ff551f to 583bf87 Compare September 2, 2021 12:24
@savitaashture savitaashture changed the title Update triggers to use v1beta1 and bump triggers, pipeline and k8s version Update triggers to use v1beta1 and bump triggers, pipeline, knative and k8s version Sep 2, 2021
@sm43
Copy link
Member

sm43 commented Sep 3, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@nikhil-thomas
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2021
@tekton-robot tekton-robot merged commit 64e147c into tektoncd:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester requested changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@sm43 sm43 Awaiting requested review from sm43

Assignees

@sm43 sm43

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@savitaashture @sm43 @nikhil-thomas @tekton-robot @vdemeester