Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenShift] Fixes rbac for Operator service account #389

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Aug 23, 2021

Operator's service account cannot create rolebinding from clusterrole
which has roles it doesn't posses for which it requires bind verb.
and to create clusteroles it requires escalate verb if roles mentioned
in clusterrole are not possesed by it.

Signed-off-by: Shivam Mukhade [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Operator's service account cannot create rolebinding from clusterrole
which has roles it doesn't posses for which it requires `bind` verb.
and to create clusteroles it requires `escalate` verb if roles mentioned
in clusterrole are not possesed by it.

Signed-off-by: Shivam Mukhade <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 23, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2021
@nikhil-thomas
Copy link
Member

/approve

Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2021
@tekton-robot tekton-robot merged commit a1a0d67 into tektoncd:main Aug 23, 2021
@sm43 sm43 deleted the fix-rbac branch October 10, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants