-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix resources not getting deleted for unique ns cron #503
Conversation
3738107
to
7d478aa
Compare
cc: @vdemeester |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue: add unique value for schedule as annotaion to a namespace. It creates a cronjob in that ns. But when the job are getting actually scheduled it does not find tekton-pipeline-conrtroller sa. Which gives error Fix: Instead of creating cronjob in other ns create it in the installation target ns. There the sa is already available. Signed-off-by: Pradeep Kumar <[email protected]>
7d478aa
to
205aa42
Compare
The following is the coverage report on the affected files.
|
/lgtm |
Issue: add unique value for schedule as annotation to a namespace.
It creates a cronjob in that ns.
But when the job is getting actually scheduled it does not find
tekton-pipeline-controller sa. Which gives error
Fix: Instead of creating cronjob in other ns create it in the
installation target ns. There the sa is already available.
Signed-off-by: Pradeep Kumar [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes