Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenShift] Fix forbidden error for community tasks #514

Merged
merged 1 commit into from
Nov 22, 2021
Merged

[OpenShift] Fix forbidden error for community tasks #514

merged 1 commit into from
Nov 22, 2021

Conversation

savitaashture
Copy link
Contributor

Changes

On disconnected cluster there could be scenario where community task URLs won't be reachable so as part of this PR adding changes to log the error and continue with next steps instead of returning error.

/cc @nikhil-thomas @concaf @vdemeester

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot
Copy link
Contributor

@savitaashture: GitHub didn't allow me to request PR reviews from the following users: concaf.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

On disconnected cluster there could be scenario where community task URLs won't be reachable so as part of this PR adding changes to log the error and continue with next steps instead of returning error.

/cc @nikhil-thomas @concaf @vdemeester

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2021
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2021
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2021
@savitaashture
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2021
@savitaashture
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2021
@savitaashture
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2021
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2021
@savitaashture savitaashture removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nikhil-thomas
nikhil-thomas suggested changes Nov 22, 2021
View reviewed changes
pkg/reconciler/openshift/tektonaddon/tektonaddon.go Outdated
}
// Continue if failed to resolve community task URL.
// (Ex: on disconnected cluster community tasks won't be reachable because of proxy).
logging.FromContext(ctx).Error("Failed to get community task ", err)
Copy link
Member

@nikhil-thomas nikhil-thomas Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logging.FromContext(ctx).Error("Failed to get community task ", err)
logging.FromContext(ctx).Error("Failed to get community task: Skipping community tasks installation ", err)

@sm43
Copy link
Member

sm43 commented Nov 22, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2021
@tekton-robot tekton-robot merged commit 44bb603 into tektoncd:main Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil-thomas nikhil-thomas nikhil-thomas requested changes

@vdemeester vdemeester vdemeester approved these changes

Assignees

@piyush-garg piyush-garg

@sm43 sm43

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@savitaashture @tekton-robot @piyush-garg @sm43 @vdemeester @nikhil-thomas