Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Catch generate_bundle() error and exit #671

Conversation

concaf
Copy link
Contributor

@concaf concaf commented Mar 10, 2022

Changes

Cherry pick #668

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 10, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2022
@sm43 sm43 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@concaf
Copy link
Contributor Author

concaf commented Mar 11, 2022

won't work but let's try
/lgtm

@tekton-robot
Copy link
Contributor

@concaf: you cannot LGTM your own PR.

In response to this:

won't work but let's try
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sm43
Copy link
Member

sm43 commented Mar 11, 2022

/lgtm
😄

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022
@concaf
Copy link
Contributor Author

concaf commented Mar 12, 2022

/retest

3 similar comments
@concaf
Copy link
Contributor Author

concaf commented Mar 12, 2022

/retest

@sm43
Copy link
Member

sm43 commented Mar 14, 2022

/retest

@concaf
Copy link
Contributor Author

concaf commented Mar 14, 2022

/retest

@tekton-robot tekton-robot merged commit 569c60d into tektoncd:release-v0.55.x Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants