Install kn tasks only on architectures with knative client

[yselkowitz]

Changes

Which, currently, does not include ARM. If/when that changes, it is suggested to simply add "arm64" instead of making these unconditional again (as was done in commit 4c80f34).

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: yselkowitz / name: Yaakov Selkowitz (ca03536)

[tekton-robot]

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yselkowitz]

/cc @concaf

[concaf]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/openshift/tektonaddon/pipelinetemplates/pipelinetemplates.go	86.2%	86.5%	0.3

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/openshift/tektonaddon/pipelinetemplates/pipelinetemplates.go	86.2%	86.5%	0.3

[yselkowitz]

tests have passed
/assign @concaf

[concaf]

/assign @nikhil-thomas @vdemeester

[nikhil-thomas]

@yselkowitz i see that this patch does two things:

1. disable installation of all kn, kn-apply ClusterTasks
2. skip the creation of +Add-flow Pipelines (default Pipelines) which use knative serving deployment as the deployment type

@pradeepitm12 what do you think about the change in the pipeline generation part.

@yselkowitz

1. could you confirm '2' is also an expected change.
2. could you add a release not mentioning both these changes.

[pradeepitm12]

👍

[pradeepitm12]

/lgtm

[yselkowitz]

1. could you confirm '2' is also an expected change.

Specifically, only on architectures which do not have OpenShift Serverless, namely arm64. This matches what was done for ppc64le and s390x when they were in a similar state, and was then dropped by 4c80f34 once Serverless was available thereon. Whenever Serverless does become available on ARM, instead of removing these conditionals again, I suggest that "arm64" simply be added to the list of knative architectures.

2. could you add a release not mentioning both these changes.

There should be no effect for existing users (which are on X/P/Z), this is only a prerequisite of the general ARM enablement.

[nikhil-thomas]

390x when they were in a similar state, and was then dropped by 4c80f34 once Serverless was available thereon. Whenever Serverless does become available on ARM, instead of removing these conditionals again, I suggest that "arm64" simply be added to the list of knative architectures

Thanks 👍
/lgtm
/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nikhil-thomas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment