Skip to content

Commit

Permalink
Align release-generated .ko.yaml with repo config
Browse files Browse the repository at this point in the history
This resolves disparities between the .ko.yaml normally used to build
images during development with the one generated and used during a
release (to ensure git-init and creds-init are built on the just-built
build-base image)

This won't prevent future drift.
  • Loading branch information
imjasonh authored and tekton-robot committed Jul 28, 2020
1 parent 116fadd commit 3a4d59c
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions tekton/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,15 @@ spec:
set -ex
cat <<EOF > /workspace/go/src/github.com/tektoncd/pipeline/.ko.yaml
# By default ko will build images on top of distroless
# This matches the value configured in .ko.yaml
defaultBaseImage: gcr.io/distroless/static:nonroot
baseImageOverrides:
$(inputs.params.pathToProject)/$(outputs.resources.builtCredsInitImage.url): $(inputs.params.imageRegistry)/$(inputs.params.pathToProject)/build-base:latest
$(inputs.params.pathToProject)/$(outputs.resources.builtGitInitImage.url): $(inputs.params.imageRegistry)/$(inputs.params.pathToProject)/build-base:latest
$(inputs.params.pathToProject)/$(outputs.resources.builtEntrypointImage.url): busybox # image should have shell in $PATH
# These match values configured in .ko.yaml
$(inputs.params.pathToProject)/$(outputs.resources.builtEntrypointImage.url): gcr.io/distroless/base:debug-nonroot
$(inputs.params.pathToPrjoect)/$(outputs.resources.builtGcsFetcherImage.url): gcr.io/distroless/static:latest
baseBuildOverrides:
$(inputs.params.pathToProject)/$(outputs.resources.builtControllerImage.url):
flags:
Expand Down

0 comments on commit 3a4d59c

Please sign in to comment.