Skip to content

Commit

Permalink
Remove kaniko reference in unit tests 😼
Browse files Browse the repository at this point in the history
Follow-up of gh:#269.

Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester authored and knative-prow-robot committed Nov 28, 2018
1 parent ce42df0 commit 57367eb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
14 changes: 5 additions & 9 deletions pkg/reconciler/v1alpha1/taskrun/entrypoint/entrypoint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,17 @@ import (
"github.com/knative/build-pipeline/pkg/reconciler/v1alpha1/taskrun/entrypoint"
)

const (
kanikoImage = "gcr.io/kaniko-project/executor"
)

func TestAddEntrypoint(t *testing.T) {
inputs := []corev1.Container{
{
Image: kanikoImage,
Image: "image",
},
{
Image: kanikoImage,
Image: "image:tag",
Args: []string{"abcd"},
},
{
Image: kanikoImage,
Image: "my.registry.svc/image:tag",
Command: []string{"abcd"},
Args: []string{"efgh"},
},
Expand Down Expand Up @@ -145,7 +141,7 @@ func TestGetRemoteEntrypoint(t *testing.T) {
Entrypoint: expectedEntrypoint,
},
})
expectedRepo := "kaniko"
expectedRepo := "image"
configPath := fmt.Sprintf("/v2/%s/blobs/%s", expectedRepo, mustConfigName(t, img))
manifestPath := fmt.Sprintf("/v2/%s/manifests/latest", expectedRepo)

Expand All @@ -168,7 +164,7 @@ func TestGetRemoteEntrypoint(t *testing.T) {
}
}))
defer server.Close()
image := path.Join(strings.TrimPrefix(server.URL, "http://"), "kaniko:latest")
image := path.Join(strings.TrimPrefix(server.URL, "http://"), "image:latest")
ep, err := entrypoint.GetRemoteEntrypoint(entrypoint.NewCache(), image)
if err != nil {
t.Errorf("couldn't get entrypoint remote: %v", err)
Expand Down
1 change: 0 additions & 1 deletion pkg/reconciler/v1alpha1/taskrun/taskrun_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ const (
entrypointLocation = "/tools/entrypoint"
toolsMountName = "tools"
pvcSizeBytes = 5 * 1024 * 1024 * 1024 // 5 GBs
kanikoImage = "gcr.io/kaniko-project/executor"
)

var ignoreLastTransitionTime = cmpopts.IgnoreTypes(duckv1alpha1.Condition{}.LastTransitionTime.Inner.Time)
Expand Down

0 comments on commit 57367eb

Please sign in to comment.