Skip to content

Commit

Permalink
linting: show all the issues 👿
Browse files Browse the repository at this point in the history
By default `golangci-lint` shows only a given number of issues (to not
overload the user with information if there is to much to fix). On the
CI we should display all of them.

Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester authored and tekton-robot committed Feb 6, 2020
1 parent 38203ea commit 6bbd47f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/presubmit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ source $(git rev-parse --show-toplevel)/vendor/github.com/tektoncd/plumbing/scri

function post_build_tests() {
header "running golangci-lint"
golangci-lint run --deadline 5m
# deadline of 5m, and show all the issues
golangci-lint run --max-issues-per-linter=0 --max-same-issues=0 --deadline 5m
}

# We use the default build, unit and integration test runners.
Expand Down

0 comments on commit 6bbd47f

Please sign in to comment.