-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds an initial implementation for conditionals
In this implementation, condition evaluations aka ConditionChecks are backed by TaskRuns. All conditionChecks associated with a `PipelineTask` have to succeed before the task is executed. If a ConditionCheck fails, the PipelineTask's associated TaskRun is marked failed i.e. its `Status.ConditionSucceeded` is False. However, the PipelineRun itself is not marked as failed. Signed-off-by: Dibyo Mukherjee <[email protected]>
- Loading branch information
1 parent
cea4f32
commit 8f84f03
Showing
14 changed files
with
1,654 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| apiVersion: tekton.dev/v1alpha1 | ||
| kind: Condition | ||
| metadata: | ||
| name: always-true | ||
| spec: | ||
| check: | ||
| image: alpine | ||
| command: ["/bin/sh"] | ||
| args: ['-c', 'exit 0'] | ||
| --- | ||
| apiVersion: tekton.dev/v1alpha1 | ||
| kind: PipelineResource | ||
| metadata: | ||
| name: pipeline-git | ||
| spec: | ||
| type: git | ||
| params: | ||
| - name: revision | ||
| value: master | ||
| - name: url | ||
| value: https://github.com/tektoncd/pipeline | ||
| --- | ||
| apiVersion: tekton.dev/v1alpha1 | ||
| kind: Task | ||
| metadata: | ||
| name: list-files | ||
| spec: | ||
| inputs: | ||
| resources: | ||
| - name: workspace | ||
| type: git | ||
| steps: | ||
| - name: run-ls | ||
| image: ubuntu | ||
| command: ["/bin/bash"] | ||
| args: ['-c', 'ls -al ${inputs.resources.workspace.path}'] | ||
| --- | ||
| apiVersion: tekton.dev/v1alpha1 | ||
| kind: Pipeline | ||
| metadata: | ||
| name: list-files-pipeline | ||
| spec: | ||
| resources: | ||
| - name: source-repo | ||
| type: git | ||
| tasks: | ||
| - name: list-files-1 | ||
| taskRef: | ||
| name: list-files | ||
| conditions: | ||
| - conditionRef: "always-true" | ||
| resources: | ||
| inputs: | ||
| - name: workspace | ||
| resource: source-repo | ||
| --- | ||
| apiVersion: tekton.dev/v1alpha1 | ||
| kind: PipelineRun | ||
| metadata: | ||
| name: demo-condtional-pr | ||
| spec: | ||
| pipelineRef: | ||
| name: list-files-pipeline | ||
| serviceAccount: 'default' | ||
| resources: | ||
| - name: source-repo | ||
| resourceRef: | ||
| name: pipeline-git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| Copyright 2019 The Tekton Authors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1_test | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| corev1 "k8s.io/api/core/v1" | ||
| "knative.dev/pkg/apis" | ||
|
|
||
| "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1alpha1" | ||
| tb "github.com/tektoncd/pipeline/test/builder" | ||
| ) | ||
|
|
||
| func TestConditionCheck_IsDone(t *testing.T) { | ||
| tr := tb.TaskRun("", "", tb.TaskRunStatus(tb.StatusCondition( | ||
| apis.Condition{ | ||
| Type: apis.ConditionSucceeded, | ||
| Status: corev1.ConditionFalse, | ||
| }, | ||
| ))) | ||
|
|
||
| cc := v1alpha1.ConditionCheck(*tr) | ||
| if !cc.IsDone() { | ||
| t.Fatal("Expected conditionCheck status to be done") | ||
| } | ||
| } | ||
|
|
||
| func TestConditionCheck_IsSuccessful(t *testing.T) { | ||
| tr := tb.TaskRun("", "", tb.TaskRunStatus(tb.StatusCondition( | ||
| apis.Condition{ | ||
| Type: apis.ConditionSucceeded, | ||
| Status: corev1.ConditionTrue, | ||
| }, | ||
| ))) | ||
|
|
||
| cc := v1alpha1.ConditionCheck(*tr) | ||
| if !cc.IsDone() { | ||
| t.Fatal("Expected conditionCheck status to be done") | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.