Skip to content

Commit

Permalink
Use vendored version of plumbing instead of go get 🦸
Browse files Browse the repository at this point in the history
Using `go get -d` updates continuously the plumbing dependency,
without really updating the vendor folder, which will mean inconsistency.

Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester authored and tekton-robot committed Dec 19, 2019
1 parent aa4d9c0 commit 9fc8bcf
Show file tree
Hide file tree
Showing 12 changed files with 1,673 additions and 6 deletions.
3 changes: 1 addition & 2 deletions hack/update-codegen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

go get -d github.com/tektoncd/plumbing
source $(go list -m -f '{{.Dir}}' github.com/tektoncd/plumbing)/scripts/library.sh
source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/library.sh

SCRIPT_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
CODEGEN_PKG=${CODEGEN_PKG:-$(go list -m -f '{{.Dir}}' k8s.io/code-generator)}
Expand Down
3 changes: 1 addition & 2 deletions hack/update-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

go get -d github.com/tektoncd/plumbing
source $(go list -m -f '{{.Dir}}' github.com/tektoncd/plumbing)/scripts/library.sh
source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/library.sh

cd ${REPO_ROOT_DIR}

Expand Down
3 changes: 1 addition & 2 deletions hack/verify-codegen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

go get -d github.com/tektoncd/plumbing
source $(go list -m -f '{{.Dir}}' github.com/tektoncd/plumbing)/scripts/library.sh
source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/library.sh

readonly TMP_DIFFROOT="$(mktemp -d ${REPO_ROOT_DIR}/tmpdiffroot.XXXXXX)"

Expand Down
27 changes: 27 additions & 0 deletions test/dummy_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// +build e2e

// Copyright © 2018 The Tekton Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package test

import (
"testing"

_ "github.com/tektoncd/plumbing/scripts"
)

func TestDummy(t *testing.T) {
t.Log("This is required to make sure we get tektoncd/plumbing in the repository, folder vendor")
}
271 changes: 271 additions & 0 deletions vendor/github.com/tektoncd/plumbing/scripts/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions vendor/github.com/tektoncd/plumbing/scripts/dummy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 9fc8bcf

Please sign in to comment.