Skip to content

Commit

Permalink
Make results in Run status optional
Browse files Browse the repository at this point in the history
If it's optional in the spec, it should probably be optional in the
Status, since the behaviour would probably be not to upload the logs
anywhere if no endpoint is provided.

Possibly in the future these could become mandator, depending how we
design the results store interface.
  • Loading branch information
bobcatfish authored and knative-prow-robot committed Dec 4, 2018
1 parent 0560f2b commit b72bd1f
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 4 deletions.
3 changes: 2 additions & 1 deletion pkg/apis/pipeline/v1alpha1/pipelinerun_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ type PipelineTriggerRef struct {
type PipelineRunStatus struct {
Conditions duckv1alpha1.Conditions `json:"conditions"`
// In #107 should be updated to hold the location logs have been uploaded to
Results Results `json:"results"`
// +optional
Results *Results `json:"results,omitempty"`
// map of TaskRun Status with the taskRun name as the key
//+optional
TaskRuns map[string]TaskRunStatus `json:"taskRuns,omitempty"`
Expand Down
3 changes: 2 additions & 1 deletion pkg/apis/pipeline/v1alpha1/taskrun_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ type TaskRunStatus struct {
Conditions duckv1alpha1.Conditions `json:"conditions,omitempty"`

// In #107 should be updated to hold the location logs have been uploaded to
Results Results `json:"results"`
// +optional
Results *Results `json:"results,omitempty"`

// PodName is the name of the pod responsible for executing this task's steps.
PodName string `json:"podName"`
Expand Down
20 changes: 18 additions & 2 deletions pkg/apis/pipeline/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b72bd1f

Please sign in to comment.