Add more skeleton code for Task validation.

The SetDefaults() and Validate() methods are required to implement the
knantive.pkg.webhook.GenericCRD interface, which allows registration in
the webhook.AdmissionController server.

cmd/webhook/main.go

@@ -84,6 +84,7 @@ func main() {
 		Options: options,
 		Handlers: map[schema.GroupVersionKind]webhook.GenericCRD{
 			v1alpha1.SchemeGroupVersion.WithKind("Pipeline"): &v1alpha1.Pipeline{},
+			v1alpha1.SchemeGroupVersion.WithKind("Task"):     &v1alpha1.Task{},
 		},
 		Logger: logger,
 	}

pkg/apis/pipeline/v1alpha1/task_defaults.go

@@ -0,0 +1,25 @@
+/*
+Copyright 2018 The Knative Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1alpha1
+
+func (t *Task) SetDefaults() {
+	t.Spec.SetDefaults()
+}
+
+func (ts *TaskSpec) SetDefaults() {
+	return
+}

pkg/apis/pipeline/v1alpha1/task_types.go

@@ -18,6 +18,8 @@ package v1alpha1
 
 import (
 	buildv1alpha1 "github.com/knative/build/pkg/apis/build/v1alpha1"
+
+	"github.com/knative/pkg/webhook"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
@@ -26,7 +28,7 @@ type TaskSpec struct {
 	// +optional
 	Inputs *Inputs `json:"inputs,omitempty"`
 	// +optional
-	Outputs   *Outputs                 `json:"outputs,omitempty"`
+	Outputs   *Outputs                `json:"outputs,omitempty"`
 	BuildSpec buildv1alpha1.BuildSpec `json:"buildSpec"`
 }
 
@@ -36,6 +38,9 @@ type TaskStatus struct {
 	// Important: Run "make" to regenerate code after modifying this file
 }
 
+// Assert that Task implements the GenericCRD interface.
+var _ webhook.GenericCRD = (*Task)(nil)
+
 // +genclient
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 

pkg/apis/pipeline/v1alpha1/task_validation.go

@@ -0,0 +1,37 @@
+/*
+Copyright 2018 The Knative Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1alpha1
+
+import (
+	"github.com/knative/pkg/apis"
+	"k8s.io/apimachinery/pkg/api/equality"
+)
+
+func (t *Task) Validate() *apis.FieldError {
+	if err := validateObjectMetadata(t.GetObjectMeta()); err != nil {
+		return err.ViaField("metadata")
+	}
+	return nil
+}
+
+func (ts *TaskSpec) Validate() *apis.FieldError {
+	if equality.Semantic.DeepEqual(ts, &TaskSpec{}) {
+		return apis.ErrMissingField(apis.CurrentField)
+	}
+
+	return nil
+}