Variable substitution and bracket notation for name encoding

[skaegi]

For Kubernetes names the set of allowable characters is ... digits (0-9), lower case letters (a-z),-, and .. We dereference with $(params.param_name}) so if we have a param name or task name that contains . things can get weird (even if they happen to work in some cases).

The Downward API has a similar problem with fieldRef and handles it by always using bracket notation for name fields ... e.g. $(params['parm_name']). Bracket notation solves the general problem however, I like the convenience of regular dot notation so think we should consider supporting both formats.

[dlorenc]

+1 on supporting both.

[bobcatfish]

sgtm!

[skaegi]

/assign

[bobcatfish]

@skaegi just wanted to check in - we have this in our 0.10 milestone ~jan 17, do you think its reasonable to finish before then, and/or would you like someone else to work on this as well?

[skaegi]

Hopefully should have something this week on this.

[skaegi]

Also see tektoncd/triggers#178

[skaegi]

[WIP] I was doing work on this here -- https://github.com/skaegi/pipeline/commits/parameterizable_validation
See skaegi@3db99e4

I'll get back to this post-beta

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bobcatfish]

@skaegi @dlorenc do we feel strongly about this and want to re-open it?

[ghost]

Worth noting that there's a maybe more use-case-oriented issue covering similar ground here: #2958

In that issue we're discussing adding context variables for all the annotations on tasks, pipelines, taskruns and pipelineruns. Those annotation keys can include characters "/", ".", etc... Dot-style gets a bit unwieldy and maybe difficult to unambiguously parse both for a human reader as well as a computer: context.annotations.tekton.dev/pipelinerun-name.

So, at least from my pov, I think we can safely keep this closed and lean on #2958 to set a syntax precedent.