Results regex should be the same as other substitution regexes #2464
Comments
|
/kind feature |
tekton-robot
added
the
kind/feature
When results parsing was implemented, the set of allowed characters wasn't made to match the rest of our substitutions. This duplicates the set of characters though hopefully we can eventually consolidate this logic. I discovered this when trying to use the kaniko task in the catalog https://github.com/tektoncd/catalog/blob/v1beta1/kaniko/kaniko.yaml Part of tektoncd#2464.
When results parsing was implemented, the set of allowed characters wasn't made to match the rest of our substitutions. This duplicates the set of characters though hopefully we can eventually consolidate this logic. I discovered this when trying to use the kaniko task in the catalog https://github.com/tektoncd/catalog/blob/v1beta1/kaniko/kaniko.yaml Part of #2464.
|
I think that #2471 doesn't totally address this b/c the logic is spread across multiple regexes in 2 different packages so I'm reopening this |
When results parsing was implemented, the set of allowed characters wasn't made to match the rest of our substitutions. This duplicates the set of characters though hopefully we can eventually consolidate this logic. I discovered this when trying to use the kaniko task in the catalog https://github.com/tektoncd/catalog/blob/v1beta1/kaniko/kaniko.yaml Part of tektoncd#2464. (cherry picked from commit fc2bf79)
When results parsing was implemented, the set of allowed characters wasn't made to match the rest of our substitutions. This duplicates the set of characters though hopefully we can eventually consolidate this logic. I discovered this when trying to use the kaniko task in the catalog https://github.com/tektoncd/catalog/blob/v1beta1/kaniko/kaniko.yaml Part of #2464. (cherry picked from commit fc2bf79)
|
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
|
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
|
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
tekton-robot
added
lifecycle/rotten
|
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Expected Behavior
We should permit the same characters in substitution for Task results as we do for other subsitutions.
Actual Behavior
The results variable replacement logic defines its own regex:
pipeline/pkg/apis/pipeline/v1beta1/resultref.go
Line 37 in c03323e
Which is different from the one used for other substitution:
pipeline/pkg/substitution/substitution.go
Line 27 in 0452a0f
This means the results regex, doesn't allow for the same set of characters, for example it does not allow the name of a variable to contain
_The text was updated successfully, but these errors were encountered: