Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support for Pipeline *and* tasks #3090

Closed
vdemeester opened this issue Aug 11, 2020 · 8 comments
Closed

Proxy support for Pipeline *and* tasks #3090

vdemeester opened this issue Aug 11, 2020 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@vdemeester
Copy link
Member

Feature request

This is probably worth splitting into two issues, but here goes.

As an admin, I want the tekton controllers installed to use users network proxy settings defined for the platform so that both the tekton controllers as well as the Task or Pipeline steps / user workloads can access images, git repos, etc through our organizations proxy and with custom certificates.

Why is this important?
To enable customer installs of the tekton to have network communications using the to use global proxy settings

Note: this is only for tektoncd/pipeline but it does affect other components (tektoncd/triggers, …). It also, most likely, need to be a TEP I guess.

/cc @sbose78 @afrittoli @bobcatfish

Use case

A user sets up tekton in a cluster that uses a global proxy for network communications. It should work : aka tasks should be able to communicate with the outside world through the proxy (if what is in the tasks supports that of course), the different tekton components should go through the proxy too when doing network query ; for tektoncd/pipeline, it might be when querying the oci registry for the image config, …

Parts

There is actually few parts for that issue :

  • How the user can provide the proxy configuration ? (through a configmap seems the best)
  • Support for proxy's environment variables inside tektoncd/pipeline code (cmd/controller, cmd/webhook, …)
  • How the controller/admission webhook can add those at runtime ? (this requires Provide mechanism to set environment variables on TaskRuns #1606 to work)
@vdemeester vdemeester added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 11, 2020
@piyush-garg
Copy link
Contributor

/assign

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2020
@piyush-garg
Copy link
Contributor

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2020
@bobcatfish
Copy link
Collaborator

Note we have a start to a TEP about this in tektoncd/community#232

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2021
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 30, 2021
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants