-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI build tests should use combined build image and build Windows images #5177
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
I'm going to wait to open a PR until #5174 is dealt with, since the build would fail anyway. |
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this issue
Jul 20, 2022
closes tektoncd#5177 Signed-off-by: Andrew Bayer <[email protected]>
7 tasks
...ok, yeah, I didn't wait to open a PR. 🤷 |
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this issue
Jul 20, 2022
closes tektoncd#5177 Signed-off-by: Andrew Bayer <[email protected]>
cc @imjasonh |
tekton-robot
pushed a commit
that referenced
this issue
Jul 21, 2022
closes #5177 Signed-off-by: Andrew Bayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As revealed by #5174, we're not actually build Windows images in
pull-tekton-pipeline-build-tests
, which resulted in code that can't compile on Windows slipping through in a PR. We should be setting Windows-supporting combined build images inko_resolve
intest/presubmit-tests.sh
in the same sort of way we are inpipeline/tekton/publish.yaml
Lines 96 to 113 in 94055d9
We can probably just use
gcr.io/tekton-releases/github.com/tektoncd/pipeline/combined-base-image:latest
for that combined base image, rather than generating a new one each time./kind bug
The text was updated successfully, but these errors were encountered: