Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky TestPipelineRun when provisioning pvcs #915

Closed
chmouel opened this issue May 28, 2019 · 3 comments · Fixed by #916
Closed

Flaky TestPipelineRun when provisioning pvcs #915

chmouel opened this issue May 28, 2019 · 3 comments · Fixed by #916
Assignees
Labels
area/testing Issues or PRs related to testing kind/bug Categorizes issue or PR as related to a bug.

Comments

@chmouel
Copy link
Member

chmouel commented May 28, 2019

Expected Behavior

When the cloud provider volume are slow to deprovision, the test fails due of failing to delete the PVC .

Actual Behavior

Fails without even trying again 😢

Additional Info

 pipelinerun_test.go:185: PVC pipelinerun1-pvc still exists after PipelineRun pipelinerun1 has completed: &PersistentVolumeClaim{ObjectMeta:k8s_io_apimachinery_pkg_apis_meta_v1.ObjectMeta{Name:pipelinerun1-pvc,GenerateName:,Namespace:arendelle-mqvsl,SelfLink:/api/v1/namespaces/arendelle-mqvsl/persistentvolumeclaims/pipelinerun1-pvc,UID:f15546ed-80e7-11e9-ab9a-1292abff36cc,ResourceVersion:16028,Generation:0,CreationTimestamp:2019-05-28 01:28:48 +0000 UTC,DeletionTimestamp:<nil>,DeletionGracePeriodSeconds:nil,Labels:map[string]string{},Annotations:map[string]string{},OwnerReferences:[{tekton.dev/v1alpha1 PipelineRun pipelinerun1 e9891d43-80e7-11e9-b427-0af0f4807604 0xc420a06d9b 0xc420a06d9c}],Finalizers:[kubernetes.io/pvc-protection],ClusterName:,Initializers:nil,},Spec:PersistentVolumeClaimSpec{AccessModes:[ReadWriteOnce],Resources:ResourceRequirements{Limits:ResourceList{},Requests:ResourceList{storage: {{5368709120 0} {<nil>} 5Gi BinarySI},},},VolumeName:,Selector:nil,StorageClassName:*gp2,VolumeMode:*Filesystem,DataSource:nil,},Status:PersistentVolumeClaimStatus{Phase:Pending,AccessModes:[],Capacity:ResourceList{},Conditions:[],},}
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 28, 2019
@abayer
Copy link
Contributor

abayer commented May 28, 2019

...sorry. =(

@vdemeester
Copy link
Member

/area testing

@tekton-robot tekton-robot added the area/testing Issues or PRs related to testing label May 28, 2019
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 28, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes bug tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel
Copy link
Member Author

chmouel commented May 28, 2019

/assign

chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 28, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 28, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 29, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 29, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 30, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 30, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 30, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 30, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue May 30, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes tektoncd#915

Signed-off-by: Chmouel Boudjnah <[email protected]>
tekton-robot pushed a commit that referenced this issue May 30, 2019
Let's poll for up to 10mn that the PersistentVolumeClaims has the
DeletionTimestamp set.

Fixes #915

Signed-off-by: Chmouel Boudjnah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants