Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document API change policy 👩 ⚖️ #1177

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

bobcatfish
Copy link
Collaborator

Changes

This commit adds docs about the policy the current governing board has been
discussing around how to handle API changes and make sure they are
reviewed by the ppl that should review them.

We can adjust this policy as needed, e.g. if we start running into
situations where not enough owners can review within a reasonable amount
of time.

Also added links to the doc where we are working on our plan to get to
Beta and updated our docs about this.

Fixes #906

@vdemeester @dlorenc @imjasonh @abayer @dibyom @afrittoli

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

This commit adds docs about the policy the current governing board has been
discussing around how to handle API changes and make sure they are
reviewed by the ppl that should review them.

We can adjust this policy as needed, e.g. if we start running into
situations where not enough owners can review within a reasonable amount
of time.

Also added links to the doc where we are working on our plan to get to
Beta and updated our docs about this.

Fixes tektoncd#906
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Aug 8, 2019
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2019
@abayer
Copy link
Contributor

abayer commented Aug 8, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2019
@abayer
Copy link
Contributor

abayer commented Aug 8, 2019

Though something seems wrong with the plumbing - https://storage.googleapis.com/tekton-prow/pr-logs/pull/tektoncd_pipeline/1177/pull-tekton-pipeline-integration-tests/1159523869577449474/build-log.txt didn't actually, y'know, run the integration tests. @vdemeester? =)

@tekton-robot tekton-robot merged commit 6e11b60 into tektoncd:master Aug 8, 2019
@abayer
Copy link
Contributor

abayer commented Aug 8, 2019

Ignore me, our presubmit tests script is smart enough to realize when it doesn't need to run the tests. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formalize review requirements for API changes
4 participants