Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tekton's nightly-built build-base image #1352

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

imjasonh
Copy link
Member

Apparently the knative-nightly build-base image hasn't been built since
February?!

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Sep 24, 2019
@tekton-robot tekton-robot requested review from a user and vdemeester September 24, 2019 20:03
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2019
@ghost
Copy link

ghost commented Sep 24, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Sep 24, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019
@imjasonh imjasonh closed this Sep 24, 2019
@imjasonh imjasonh reopened this Sep 24, 2019
@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@chmouel
Copy link
Member

chmouel commented Sep 25, 2019

/retest
/lgtm

@vdemeester
Copy link
Member

/test pull-tekton-pipeline-integration-tests

Apparently the knative-nightly build-base image hasn't been built since
February?!
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ImJasonH,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 40e340f into tektoncd:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants