Only mount artifact bucket volume once, even with multiple inputs. #1370
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
size/L
|
Hi @jbarrick-mesosphere. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
/approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This fixes an issue where an artifact bucket secret can be mounted multiple times if there are multiple inputs that copy from another task.
jbarrick-mesosphere
force-pushed
the
multiple-inputs
branch
from
7d6d22e to
ca0d8cd
Compare
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
/lgtm |
This fixes an issue where a Task that uses a secret for both input and output resources leads to duplicate volumes in the generated Pod. This happens because both `resources.AddInputResource()` and `resources.AddOutputResources()` mount the necessary secrets to load artifacts. However, when multiple resources use the same secret the secret volume is added twice and leads to an invalid PodSpec. This fix extends the work done in tektoncd#1370
This fixes an issue where a Task that uses a secret for both input and output resources leads to duplicate volumes in the generated Pod. This happens because both `resources.AddInputResource()` and `resources.AddOutputResources()` mount the necessary secrets to load artifacts. However, when multiple resources use the same secret the secret volume is added twice and leads to an invalid PodSpec. This fix extends the work done in tektoncd#1370 (cherry picked from commit 1bcbe43)
This fixes an issue where a Task that uses a secret for both input and output resources leads to duplicate volumes in the generated Pod. This happens because both `resources.AddInputResource()` and `resources.AddOutputResources()` mount the necessary secrets to load artifacts. However, when multiple resources use the same secret the secret volume is added twice and leads to an invalid PodSpec. This fix extends the work done in #1370
Changes
This fixes an issue where an artifact bucket secret can be mounted multiple times if there are multiple inputs that copy
from another task.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes