-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a subfolder in the release bucket #1391
Use a subfolder in the release bucket #1391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Just in time @afrittoli !! 😆 @afrittoli can you also update our installation docs? https://github.com/tektoncd/pipeline/blob/master/docs/install.md#installing-tekton-pipelines-1 If we want to move the existing releases to this structure also i recommend we copy them (at least initially) so anyone trying to install based on the old location still can |
@afrittoli can you add "Closes #57" in the description to closes the issue 👼 |
uhm, that would point to pipeline #57 |
dang… "Closes tektoncd/plumbing#57" then 😝 |
The tekton release bucket shall host releases for all relevant tekton projects. Pipeline should use its own dedicated subfolder. Closes tektoncd/plumbing#57
d1ff217
to
c28d006
Compare
Updated the docs, and created a copy of previous releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can we cancel the hold now? |
indeed 😝 |
The tekton release bucket shall host releases for all relevant
tekton projects. Pipeline should use its own dedicated subfolder.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes