-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused results field from pr and tr specs #1425
Conversation
The `results` field is unused, was deprecated in 0.7, and was scheduled to be removed in the 0.8 release Co-authored-by: Daniel Helfand <[email protected]> Signed-off-by: Dibyo Mukherjee <[email protected]>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
/lgtm |
The following is the coverage report on pkg/.
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Daniel has previously committed to pipelines so I'm guessing its the co-authorship that messed up the CLA |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dibyom Thanks for the co-authorship! |
Changes
Fixes #1243
The
results
field is unused, was deprecated in 0.7, and wasscheduled to be removed in the 0.8 release
Co-authored-by: Daniel Helfand [email protected]
Signed-off-by: Dibyo Mukherjee [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes