go.mod changes: less replace #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Demeester <[email protected]>
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
|
/cc @wlynch |
vdemeester
commented
Dec 16, 2019
| ) | ||
|
|
||
| // Local overrides for testing. Remove before submitting. |
There was a problem hiding this comment.
@wlynch we forgot to remove before merging 😅
vdemeester
force-pushed
the
go-mod-clean
branch
from
6498c35 to
a0151e6
Compare
tekton-robot
added
size/L
|
ok nevermind, the |
At least we now it needs to be replaced… Signed-off-by: Vincent Demeester <[email protected]>
|
/lgtm |
|
/lgtm Thanks 👍🏼🔥 |
afrittoli
reviewed
Dec 19, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes as much
replaceas possible as they won't "transpire" in modules depending ontektoncd/pipeline. I thinkreplaceshould be used as last resort (a bit like[[override]]was to be used usingdep). There is two commits in there:go.mod: remove replace for kubernetesFor kubernetes, putting kubernetes inreplacemeans we don't telldependency which version we are depending too, which could lead with
compilation failure (as they would get higher version).
For plumbing, this allows to do a
go get -u github.com/tektoncd/plumbingand actually depending on what was updated.NB: we need to had a check on the
vendorfolder, to make sure thevendorfolder is in sync with thego.mod.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.