Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripts without shebang start. #1909

Closed
wants to merge 1 commit into from
Closed

Fix scripts without shebang start. #1909

wants to merge 1 commit into from

Conversation

bigkevmcd
Copy link
Member

Changes

This fixes some remaining scripts in example TaskRuns that are missing shebang
scripts, triggering an error if applied.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Fix example TaskRuns with missing shebangs in scripts.

This fixes some remaining scripts in example TaskRuns that are missing shebang
scripts, triggering an error if applied.
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dibyom
You can assign the PR to them by writing /assign @dibyom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 21, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2020
@vdemeester
Copy link
Member

@bigkevmcd I think those are meant to test (and make sure) that script works without shebang (in master). As written in #1904 (comment), 0.9.x needs shebang, but starting from 0.10 (soon to be released), you won't need it (if it's a bash script), as #1691 implemented (and #1736).

@tekton-robot
Copy link
Collaborator

@bigkevmcd: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-pipeline-integration-tests be8d600 link /test pull-tekton-pipeline-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bigkevmcd bigkevmcd closed this Jan 21, 2020
@bigkevmcd bigkevmcd deleted the fix-scripts branch January 21, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants