Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check of passed constraint should use pipeline task name #196

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Check of passed constraint should use pipeline task name #196

merged 1 commit into from
Oct 26, 2018

Conversation

nader-ziada
Copy link
Member

Check of passed constraint should use pipeline task name instead of task name to check the dependency in the pipeline
This makes writing the pipeline yaml easier
in addition also:

  • updates examples
  • updates tests

could be part of #138

/cc @tejal29 @shashwathi

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2018
@nader-ziada
Copy link
Member Author

@tejal29 this was part of your PR #178 that you closed in favor of #187, wanted to make sure we don't forget it

@nader-ziada
Check of passed constraint should use pipeline task
1c605e6 
it was using the task name to check the passed constraint dependency in
the pipeline, but should be using pipeline task name instead to have
better ux while writing the pipeline yaml
shashwathi
shashwathi approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@shashwathi shashwathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pivotal-nader-ziada, shashwathi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pivotal-nader-ziada]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 8325e78 into tektoncd:master Oct 26, 2018
@nader-ziada nader-ziada deleted the pipeline-task branch October 29, 2018 12:45
@bobcatfish
Copy link
Collaborator

Good catch, thanks @pivotal-nader-ziada !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashwathi shashwathi shashwathi approved these changes

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nader-ziada @knative-prow-robot @bobcatfish @shashwathi