Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task result substitution (#2387) #2393

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Conversation

othomann
Copy link
Contributor

Changes

Fix the issue with task results substitution when used with param substitution. See issue #2387

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Fix issue #2387

@tekton-robot tekton-robot requested review from dibyom and imjasonh April 14, 2020 20:43
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2020
@othomann
Copy link
Contributor Author

The change looks bigger than it really is. I moved some code to the v1beta1 package for pipeline validation because task/pipeline results belongs to b1beta1. Let me know if you have any concerns.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go 93.2% 96.9% 3.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 94.5% 91.7% -2.9
pkg/apis/pipeline/v1beta1/resultref.go 90.9% 93.9% 3.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go 93.2% 96.9% 3.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 94.5% 91.7% -2.9
pkg/apis/pipeline/v1beta1/resultref.go 90.9% 93.9% 3.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go 93.2% 96.9% 3.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 94.5% 91.7% -2.9
pkg/apis/pipeline/v1beta1/resultref.go 90.9% 93.9% 3.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipeline_validation.go 93.2% 96.9% 3.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go 94.5% 92.2% -2.3
pkg/apis/pipeline/v1beta1/resultref.go 90.9% 93.9% 3.0

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020
@afrittoli
Copy link
Member

@sbwsg

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
@tekton-robot tekton-robot merged commit b817a12 into tektoncd:master Apr 15, 2020
echo -n "suffix" > $(results.suffix.path)
- name: do-something
runAfter:
- generate-suffix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a runAfter here? i thought the intention was for the variable interpolation to imply the ordering?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. This is the example from the original issue.

bobcatfish added a commit to bobcatfish/pipeline that referenced this pull request Apr 23, 2020
In order to cherry pick in the fixes from tektoncd#2393 and tektoncd#2471, we first need
to apply the refactoring/changes these were built on in
tektoncd@a8946d4#diff-e2b4c96e5145aa139a97f864d9f9f2a1
but unfortunately this both refactored/changed the code, AND added
pipeline results. Since we don't want to add a new feature in a patch
release, this commit extracts the refactoring (and fix?) from that
commit.
tekton-robot pushed a commit that referenced this pull request Apr 23, 2020
In order to cherry pick in the fixes from #2393 and #2471, we first need
to apply the refactoring/changes these were built on in
a8946d4#diff-e2b4c96e5145aa139a97f864d9f9f2a1
but unfortunately this both refactored/changed the code, AND added
pipeline results. Since we don't want to add a new feature in a patch
release, this commit extracts the refactoring (and fix?) from that
commit.
@afrittoli afrittoli added the kind/bug Categorizes issue or PR as related to a bug. label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants