Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document PipelineResource's Alpha State #2447

Merged
merged 1 commit into from Apr 20, 2020
Merged

Document PipelineResource's Alpha State #2447

merged 1 commit into from Apr 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 20, 2020

Changes

Fixes #1369

During the release of Pipelines' Beta we communicated the
fact that PipelineResources are not being promoted along
with other types but we didn't include any extensive
commentary to support that decision.

This commit adds a description of the problems that remain
with PipelineResources, along with possible next steps
that the project might take with them.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@ghost ghost requested review from vdemeester, bobcatfish and afrittoli April 20, 2020 15:50
@tekton-robot tekton-robot requested a review from dlorenc April 20, 2020 15:50
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 20, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 20, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@@ -1048,6 +1056,70 @@ Data,
}
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be helpful to include a section on how to use the API in the meantime. What are the recommended ways to use Tasks and Pipelines now, if you were relying on PipelineResources before?

Maybe this is already covered in a v1alpha to beta migration guide.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, it's covered there and I've added links to it.

During the release of Pipelines' Beta we communicated the
fact that PipelineResources are not being promoted along
with other types but we didn't include any extensive
commentary to support that decision.

This commit adds a description of the problems that remain
with PipelineResources, along with possible next steps
that the project might take with them.
@ghost
Copy link
Author

ghost commented Apr 20, 2020

/test pull-tekton-pipeline-build-tests

@dlorenc
Copy link
Contributor

dlorenc commented Apr 20, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@tekton-robot tekton-robot merged commit 1346656 into tektoncd:master Apr 20, 2020
@afrittoli afrittoli added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beta documentation: write up alternatives to PipelineResources if they remain Alpha
5 participants