Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tekton.dev/task label from taskrun of clustertasks #2527

Closed
wants to merge 1 commit into from

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented May 4, 2020

This will remove the label tekton.dev/task from taskruns referencing
clustertasks. This was marked deprecated in pipeline release-v0.12.0

This PR will remove the label for next release

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Remove tekton.dev/task label from taskrun of clustertasks

This will remove the label tekton.dev/task from taskruns referencing
clustertasks. This was marked deprecated in pipeline release-v0.12.0

This PR will remove the label for next release
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dlorenc
You can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from afrittoli and dlorenc May 4, 2020 06:44
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2020
@piyush-garg
Copy link
Contributor Author

cc @bobcatfish @vdemeester @sbwsg @afrittoli @dibyom as this can be breaking change for folks using labels

And for cli, to list, for fetching last runs, and for describe commands, this will be very useful to differentiate between task and cluster tasks as this is buggy if there is task and cluster task with the same name.

@tekton-robot
Copy link
Collaborator

@piyush-garg: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-pipeline-integration-tests fdef60e link /test pull-tekton-pipeline-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ghost
Copy link

ghost commented May 5, 2020

Given deprecation of this label was only announced in 0.12.0 I suggest we close this PR until the 9 months have passed. What do others think?

@ghost
Copy link

ghost commented May 5, 2020

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020
@ghost
Copy link

ghost commented May 21, 2020

I'm going to close this one since the deprecation window is going to be open for a while. I think there are a number of folks relying on these labels at the moment. Please reopen if you think this is the wrong call though!

@ghost ghost closed this May 21, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants