Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to Alpine 3.11 so upgrade doesnt try to delete /var/run 📌 #2757

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

bobcatfish
Copy link
Collaborator

Changes

We're not quite at the bottom of
#2738 but it seems like
alpine 3.12 is having this problem and 3.11 is not. 3.12 seems to be
still being updated which may be why we are seeing different behavior
across runs using 3.12; for now pinning to 3.11 should be a way to be
able to build our releases while we try to understand what's going on.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Releases will be built from 3.11 Alpine (at least until we figure out why we're having trouble with 3.12)

@tekton-robot tekton-robot requested review from dlorenc and a user June 4, 2020 20:45
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

1 similar comment
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@dibyom
Copy link
Member

dibyom commented Jun 4, 2020

/kind bug
/approve
/lgtm

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2020
@bobcatfish bobcatfish added kind/bug Categorizes issue or PR as related to a bug. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 4, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@bobcatfish
Copy link
Collaborator Author

image

image

🤔

@bobcatfish
Copy link
Collaborator Author

image

wat

@bobcatfish
Copy link
Collaborator Author

/test pull-tekton-pipeline-unit-tests

@bobcatfish
Copy link
Collaborator Author

what fresh hell is this

@bobcatfish
Copy link
Collaborator Author

/retest

We're not quite at the bottom of
tektoncd#2738 but it seems like
alpine 3.12 is having this problem and 3.11 is not. 3.12 seems to be
still being updated which may be why we are seeing different behavior
across runs using 3.12; for now pinning to 3.11 should be a way to be
able to build our releases while we try to understand what's going on
@bobcatfish bobcatfish force-pushed the pin_to_stable_alpine branch from 9e7743f to cc8d88a Compare June 4, 2020 22:02
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@imjasonh
Copy link
Member

imjasonh commented Jun 4, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants