Add Git LFS Support to build-base image used by git-init to solve #2997

[eqqe]

Changes

Add git-lfs Alpine package to support Git LFS (https://git-lfs.github.com/) when cloning repositories.
/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Adding support for git-lfs repositories in git-init by adding the package in the git-init image

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Simon Rey (16bc50f)

[tekton-robot]

Hi @eqqe. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dlorenc]

/ok-to-test

[eqqe]

/retest

[vdemeester]

@eqqe this is gonna need a release-note entry, like "Adding support for git-lfs repositories in git-init by adding the package in the git-init image".

[eqqe]

@vdemeester I have updated the release note but the PR labels are not updated

[vdemeester]

@vdemeester I have updated the release note but the PR labels are not updated

Ah right, it needs release-note after the three backtick (`) to be taken into account, I've update the desc 😉

[dlorenc]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dlorenc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pritidesai]

/test check-pr-has-kind-label

[pritidesai]

Should we add any tests? 🤔

[dlorenc]

Should we add any tests? 🤔

The only meaningful test I can think of would be an e2e test of cloning a repo that uses Git LFS.

[ghost]

Yeah I think it would be useful to add a test around this, which I think could be most easily achieved by adding a YAML to our examples directory that uses a git server sidecar running git-lfs. It looks like there's a test server available as part of the git lfs project: https://github.com/git-lfs/lfs-test-server

For an example of creating an example YAML that uses a sidecar as a git server see

pipeline/examples/v1beta1/taskruns/authenticating-git-commands.yaml

Line 64 in 38455ba

- name: server

[vdemeester]

/lgtm

[pritidesai]

This has five commits, please squash them into one.