When expression + affinity assistant fixes for 0.16.2 #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasks with when expressions using variables that evaluated to false were mistakenly executed because it missed an additional check to validate that the task should be skipped after variable replacement. Fixes tektoncd#3188 (cherry picked from commit c12b843)
Add more information to the docs about using `Results` in `WhenExpressions`. Specifically: - add details and examples on how Results are used in WhenExpressions in addition to Parameters - change the name of the result used in the WhenExpressions examples, from status to exists to clarify that it's not the task status (cherry picked from commit 5b5fbb4)
- Rename the tasks to be clear when they are expected to be skipped - Add comments describing what each task in the example is testing - Embed the pipeline in the pipelinerun and generate the name Co-authored-by: [email protected] (cherry picked from commit c38c520)
Instead of creating a new empty array and appending resolved when expression, creating an array based on the existing one and replacing in place the resolved when expression. Also, do not evaluate when expressions until all parents are done, wait for parent tasks to be completed before evaluating when expressions. This check will make sure that tasks resulting in when expressions failures, are not declared skipped in advance before their parents are done. With when expressions having reference to task results, evaluate and apply task results before checking if its to run finally tasks. This change is necessary to make sure all the leaf nodes of DAG have resolved task results in their when expressions to evaluate whether DAG is done or not. This change of order works today since finally tasks does not need to resolve task results yet. Once we add task results support in finally, we will have to make one more call to apply task results after adding finally tasks to execution queue. (cherry picked from commit c90461f)
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
|
/lgtm |
The PipelineRun reconciler cleanup the affinity assistant when the PipelineRun is completed. If the cleanup-function is called more than once, the DELETE request will return a NotFound response. It does not make sense to return NotFound responses as an error, since this is what we want to achieve. (cherry picked from commit 204a403)
bobcatfish
changed the title
|
I've added #3212 as well - will need another lgtm (+ approve!) :) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes