Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added suport for building multi-arch images #3314

Closed
wants to merge 9 commits into from
Closed

Added suport for building multi-arch images #3314

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c9a0520
Added suport for building multi-arch images
AverageMarcus Oct 1, 2020
5a74add
Derive cancel patch bytes once at controller startup
imjasonh Oct 1, 2020
e29ecb3
Add a short example of using optional workspaces in when expressions
Sep 30, 2020
0d3ef40
tekton: migrate release task and pipeline to v1beta1
vdemeester Aug 17, 2020
2917f3b
refactoring pipelinerunstate
pritidesai Sep 16, 2020
8de599b
Prior to this commit QPS, threads-per-controller and maximum burst we…
Sep 30, 2020
cb3c444
Replace variables in Sidecar Script block
Oct 1, 2020
2f0780d
Emit an event if overwriting PodTemplate affinity
adshmh Jun 18, 2020
88f0506
Fix issue where workspace volume variable and pod volume conf differ
Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tekton/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,11 @@ spec:
OUTPUT_BUCKET_RELEASE_DIR="/workspace/output/bucket/previous/$(inputs.params.versionTag)"

# Publish images and create release.yaml
ko resolve --preserve-import-paths -t $(inputs.params.versionTag) -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > $OUTPUT_BUCKET_RELEASE_DIR/release.yaml
ko resolve --platform=all --preserve-import-paths -t $(inputs.params.versionTag) -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > $OUTPUT_BUCKET_RELEASE_DIR/release.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to work we'll need to make sure the ko image we use is updated with a recent enough ko (> version 0.6.0).

That's configured here, in the plumbing repo: https://github.com/tektoncd/plumbing/blob/master/tekton/images/ko/Dockerfile#L18

And after we make that change we'll need to rebuild and publish the image, so it can be used here.

Do you want to make the plumbing change? If not, I can to unblock you.

# Publish images and create release.notags.yaml
# This is useful if your container runtime doesn't support the `image-reference:tag@digest` notation
# This is currently the case for `cri-o` (and most likely others)
ko resolve --preserve-import-paths -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > $OUTPUT_BUCKET_RELEASE_DIR/release.notags.yaml
ko resolve --platform=all --preserve-import-paths -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > $OUTPUT_BUCKET_RELEASE_DIR/release.notags.yaml
volumeMounts:
- name: gcp-secret
mountPath: /secret
Expand Down