config: fix runAsUser inconsistency with images 🍨 #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distroless `nonroot` image define a user with the uid 65532 and not 1001. The deployment should use that uid to make sure it works anywhere. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
added
the
needs-cherry-pick
tekton-robot
added
release-note
ghost
approved these changes
Oct 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
afrittoli
reviewed
Oct 6, 2020
|
/lgtm |
|
|
|
/retest |
dibyom
added a commit
to dibyom/triggers
that referenced
this pull request
Oct 7, 2020
Port of tektoncd/pipeline#3342: The distroless nonroot image define a user with the uid 65532 and not 1001. The deployment should use that uid to make sure it works anywhere. Fixes tektoncd#781 Signed-off-by: Dibyo Mukherjee <[email protected]>
4 tasks
tekton-robot
pushed a commit
to tektoncd/triggers
that referenced
this pull request
Oct 8, 2020
Port of tektoncd/pipeline#3342: The distroless nonroot image define a user with the uid 65532 and not 1001. The deployment should use that uid to make sure it works anywhere. Fixes #781 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/dashboard
that referenced
this pull request
Oct 8, 2020
Port of tektoncd/pipeline#3342: The distroless nonroot image define a user with the uid 65532. The deployment should use that uid to make sure it works anywhere.
3 tasks
gabemontero
added a commit
to gabemontero/triggers
that referenced
this pull request
Oct 8, 2020
Merged
3 tasks
tekton-robot
pushed a commit
to tektoncd/dashboard
that referenced
this pull request
Oct 12, 2020
Port of tektoncd/pipeline#3342: The distroless nonroot image define a user with the uid 65532. The deployment should use that uid to make sure it works anywhere.
vdemeester
removed
the
needs-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #3273
The distroless
nonrootimage define a user with the uid 65532 andnot 1001. The deployment should use that uid to make sure it works anywhere.
Signed-off-by: Vincent Demeester [email protected]
/cc @imjasonh @mattmoor @tektoncd/core-maintainers
/kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes