Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestSidecarTaskSupport e2e test case fix for custom base image #3358

Closed
wants to merge 1 commit into from
Closed

TestSidecarTaskSupport e2e test case fix for custom base image #3358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/sidecar_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func TestSidecarTaskSupport(t *testing.T) {
}{{
desc: "A sidecar that runs forever is terminated when Steps complete",
stepCommand: []string{"echo", "\"hello world\""},
sidecarCommand: []string{"sh", "-c", "while [[ true ]] ; do echo \"hello from sidecar\" ; done"},
sidecarCommand: []string{"sh", "-c", "while [[ true ]] ; do echo \"hello from sidecar\" ; [[ -f /ko-app/nop ]] && break; done; ./ko-app/nop"},
}, {
desc: "A sidecar that terminates early does not cause problems running Steps",
stepCommand: []string{"echo", "\"hello world\""},
Expand Down