Improve the logging in pkg/git testing #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the "fetch" testing nicely captures logs (to examine output), but doesn't actually surface them on failures.
This change adds a `defer`red function that stream the output to `t.Log` so that `git` failures can be debugged.
For example, when I introduce a typo into the "commit" command, it now prints:
```
=== RUN TestFetch/test-clone-with-sparse-checkout
git_test.go:299: exit status 1
git_test.go:216: ["error" git]: Error running git [codmmit --allow-empty -m Hello Moto]: exit status 1
git: 'codmmit' is not a git command. See 'git --help'.
The most similar command is
commit
```
Previously, this would only print the exit status, which isn't particularly useful.
tekton-robot
added
release-note-none
tekton-robot
added
the
size/S
|
/lgtm Thanks! |
vdemeester
approved these changes
Aug 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
I think this is a flake, but gubernator displays things oddly... Let's see /retest |
|
gonna have to close/reopen to kick the kind job |
|
Hmm that didn't do it, so I'll go for a walk and try again 😉 |
|
/retest |
|
/test check-pr-has-kind-label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "fetch" testing nicely captures logs (to examine output), but doesn't actually surface them on failures.
This change adds a
deferred function that stream the output tot.Logso thatgitfailures can be debugged.For example, when I introduce a typo into the "commit" command, it now prints:
Previously, this would only print the exit status, which isn't particularly useful.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes