Switch the linter from golint to revive, and fix warnings.

[dlorenc]

Changes

This finishes up the switch from the deprecated golint to
revive, which is the replacement. This was started in #4206.

This consisted of one new lint warning, and switching some
suppressions to revive from golint.

Signed-off-by: Dan Lorenc [email protected]

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

[dlorenc]

Looks like we might have to wait for tektoncd/plumbing#882 since 1.39 throws some warnings that 1.42 doesn't.

[dlorenc]

/test pull-tekton-pipeline-build-tests

[vdemeester]

pkg/pullrequest/disk.go:99:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := refToDisk("base", path, r.PR.Base); err != nil {
		return err
	}
pkg/apis/pipeline/v1beta1/resource_types_validation.go:70:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := validateTaskRunResources(ctx, tr.Outputs, "spec.resources.outputs.name"); err != nil {
		return err
	}
pkg/apis/pipeline/v1alpha1/condition_validation.go:55:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := validateSteps([]Step{cs.Check}).ViaField("Check"); err != nil {
		return err
	}
pkg/apis/pipeline/v1alpha1/run_validation.go:73:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := validateWorkspaceBindings(ctx, rs.Workspaces); err != nil {
		return err
	}
pkg/apis/pipeline/v1alpha1/task_validation.go:143:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := validateResourceVariables(ts.Steps, ts.Inputs, ts.Outputs, ts.Resources); err != nil {
		return err
	}
pkg/apis/pipeline/v1alpha1/pipeline_validation.go:178:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := validatePipelineWorkspaces(ps.Workspaces, ps.Tasks); err != nil {
		return err
	}
pkg/termination/write.go:64:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := f.Sync(); err != nil {
		return err
	}

Failure is legit I think. Does revive do something similar to go vet, where depending on the number of errors and "gravity" they do not show everything (so after you fix something it will show new warning) ?

[dlorenc]

If I run golangci-lint 1.42 locally, I see no errors. If I run it with 1.39, I see these. My guess was that the plumbing change hadn't taken effect yet. Might be worth just fixing these though...

[dlorenc]

/test pull-tekton-pipeline-build-tests

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_validation.go	83.3%	80.0%	-3.3
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.1%	97.0%	-0.0
pkg/apis/pipeline/v1alpha1/run_validation.go	92.3%	91.7%	-0.6
pkg/apis/pipeline/v1alpha1/task_validation.go	82.8%	82.6%	-0.2
pkg/pullrequest/disk.go	79.5%	79.9%	0.4
pkg/termination/write.go	68.2%	70.0%	1.8

[dlorenc]

OK, I gave up and fixed them.

[mattmoor]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/retest