Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sbwsg from OWNERS_ALIAS file #4249

Merged
merged 1 commit into from Oct 4, 2021
Merged

Remove sbwsg from OWNERS_ALIAS file #4249

merged 1 commit into from Oct 4, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2021

Changes

I can't remember what OWNERS_ALIAS is used for.

Removing self from approvers lists here just in case
it has bearing on the mechanics of that.

A bit more context: I'm trying to reduce my footprint in open source so that I can focus a bit more on delivering features. I'm still planning to be around to review, lgtm, etc.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE

@ghost ghost added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 21, 2021
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 21, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2021
@bobcatfish
Copy link
Collaborator

@sbwsg these days OWNERS references OWNERS_ALIAS so if you remove yourself from that list your effectively stepping back from being an OWNER of Tekton Pipelines (and you won't be able to /approve)

(not sure why the productivity aliases are also in this file 🤔 )

@bobcatfish
Copy link
Collaborator

(if you're going ahead with it can you add yourself to the # Alumni ❤️ section as well?)

@ghost
Copy link
Author

ghost commented Sep 22, 2021

Perfect, cheers for clarifying!

I can't remember what this file is used for but
removing self from approvers lists just in case
this has bearing on that.
@ghost
Copy link
Author

ghost commented Sep 27, 2021

Added self to alumni section.

@ghost
Copy link
Author

ghost commented Sep 27, 2021

/test pull-tekton-pipeline-alpha-integration-tests

@vdemeester
Copy link
Member

@sbwsg these days OWNERS references OWNERS_ALIAS so if you remove yourself from that list your effectively stepping back from being an OWNER of Tekton Pipelines (and you won't be able to /approve)

(not sure why the productivity aliases are also in this file 🤔 )

They are for this repository, for the plumbing/hack part of things

@vdemeester
Copy link
Member

/approve
🥲

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2021
@jerop
Copy link
Member

jerop commented Oct 4, 2021

thank you @sbwsg for all your contributors as an owner 😻

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2021
@tekton-robot tekton-robot merged commit 1bb533b into tektoncd:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants