Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only copy output of resources when possible #428

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Only copy output of resources when possible #428

merged 1 commit into from
Jan 29, 2019

Conversation

afrittoli
Copy link
Member

Input resources may copy output from output resources from previous
tasks - do that only if the resources is an allowed type.

This is a follow-up on the work started in #414 to fix issue #401 .

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 24, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 24, 2019
vdemeester
vdemeester approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
@vdemeester
Copy link
Member

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 24, 2019
@abayer
Copy link
Contributor

abayer commented Jan 24, 2019

/lgtm

@afrittoli
Only copy output of resources when possible
609366d 
Input resources may copy output from output resources from previous
tasks - do that only if the resources is an allowed type.
@afrittoli afrittoli force-pushed the allowed_resources_inputs branch from f73bc12 to 609366d Compare January 26, 2019 21:09
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-build-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/taskrun/resources/input_resources.go 91.5% 91.6% 0.1
pkg/reconciler/v1alpha1/taskrun/resources/output_resource.go 91.5% 93.1% 1.6

vdemeester
vdemeester approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@nader-ziada
Copy link
Member

/approve
/lgtm

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, pivotal-nader-ziada, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pivotal-nader-ziada]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2019
@knative-prow-robot knative-prow-robot merged commit e9bf9fe into tektoncd:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashwathi shashwathi shashwathi left review comments

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@afrittoli @vdemeester @abayer @knative-metrics-robot @nader-ziada @knative-prow-robot @shashwathi @googlebot