Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix structure and enable toc autogenerate #4319

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Fix structure and enable toc autogenerate #4319

merged 1 commit into from
Oct 19, 2021

Conversation

koneko096
Copy link
Contributor

@koneko096 koneko096 commented Oct 16, 2021 •
edited by pritidesai
Loading

Fixes #4272

Changes

Adding tag for future ToC inline updates. mdtoc inline mode requires tag to be there. Also, fixing some content structure.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Fix structure and enable toc autogenerate

@koneko096
Fix structure and enable tic autogenerate
9b96b10 
TOC should be called using `mdtoc --inline` command. Inline mode requires toc tag to be there.
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 16, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 16, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@tekton-robot tekton-robot requested review from dlorenc and jerop October 16, 2021 17:11
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2021
@tekton-robot
Copy link
Collaborator

Hi @koneko096. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 16, 2021
@pritidesai
Copy link
Member

/ok-to-test

thank you @koneko096 for your contributions 🙏

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
jerop
jerop reviewed Oct 19, 2021
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @koneko096!

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021
@tekton-robot tekton-robot merged commit 5dcd434 into tektoncd:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop left review comments

@pritidesai pritidesai pritidesai approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update toc of pipelineruns.md
4 participants
@koneko096 @tekton-robot @pritidesai @jerop