Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non terminal pod exists #4742

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Non terminal pod exists #4742

merged 1 commit into from
Jun 30, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Apr 7, 2022 •
edited by afrittoli
Loading

Changes

If for some reason the pod fails to be created because it already exists, do not treat it as a
terminal failure. More background in #4741

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

If for some reason between getting the pod with a list and creation it already exists, do not
treat it as a terminal failure.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 7, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 79.9% 79.7% -0.3

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2022
@vdemeester
Copy link
Member

ping @vaikas

@vaikas
Copy link
Contributor Author

vaikas commented Jun 7, 2022

@vdemeester this one builds on top of #4740 so I'd rather rebase after/if that gets merged.

@afrittoli
Copy link
Member

@vdemeester this one builds on top of #4740 so I'd rather rebase after/if that gets merged.

#4740 is merged now :)

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 22, 2022
afrittoli
afrittoli reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
It would be great to have test coverage for this new case.

@vaikas
Copy link
Contributor Author

vaikas commented Jun 27, 2022

Fantastic, thanks. I was out on PTO so I'll be taking a look this week.

@vaikas vaikas force-pushed the non-terminal-pod-exists branch from ea1b381 to f565666 Compare June 27, 2022 13:08
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 81.6% 81.1% -0.6

@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@tekton-robot tekton-robot merged commit 9b769ab into tektoncd:main Jun 30, 2022
@vaikas vaikas deleted the non-terminal-pod-exists branch July 5, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@vdemeester vdemeester vdemeester approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@abayer abayer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vaikas @tekton-robot @vdemeester @afrittoli @abayer